Thu Sep  9 10:10:14 PDT 1993
by Ross Oliver, NCD Tech Support


Bug fixes that should be made to all Xremote 2.4.8 ports:



In Xremote/helper/main.c, line 1713 reads:

    if (select(curClient->buf->inbuf.fd + 1, set, NULL, NULL, &notime) < 0) {

Add "&" before the "set" parameter so the line reads:

    if (select(curClient->buf->inbuf.fd + 1, &set, NULL, NULL, &notime) < 0) {


In Xremote/xinitremote/xinitremote.c, line 617 reads:

    strncpy(newname, tmpfilename, tmpdir - tmpfilename);

Not all versions of strncpy append a null character after copying the
string, so to prevent possible malloc corruption and core dumps, add
the following line after line 617:

    newname[tmpdir-tmpfilename] = '\0';


In Xremote/helper/bs_unix.c, line 222 reads:

    ttystruct.c_cflag &= (CIBAUD|CBAUD);

Add a tilde before the open parantheses so the line reads:

    ttystruct.c_cflag &= ~(CIBAUD|CBAUD);



In Xremote/helper/main.c, declare the variable nextReqData
to be static int.


In Xremote/helper/main.c, change the declaration of NeedNewTime
on line 181 from "extern Bool" to "static Bool", and initialize
to TRUE.  Delete the later declaration on line 1751.